Re: [PATCH 3/4] ci(gitlab,windows): fix Rust setup for GitLab's MinGW build

From: Junio C Hamano <gitster@pobox.com>
Date: Sep 28, 2026, 14:33 UTC
Message-ID: <xmqq8q4lphs5.fsf@gitster.g>
In-Reply-To: <aroOJHlxCs9Rnwv-@pks.im>

Patrick Steinhardt <ps@pks.im> writes:

>> > Are we sure that PATH cannot ever contain spaces or should we rather
>> > quote here?
>> ...
> Well, TIL :)

Our coding guidelines share some blame. As some implementations of shells historically were buggy when assignment is combined with modifers (e.g., "export var=val") and split the right hand side at $IFS, we strongly encourage assignment to be written with right hand side quoted even when you shouldn't have to. Uniformly applying the safer rule is easier on mere mortals than knowing and remembering exactly when we do not have to quote and omitting the quote ;-).

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.