git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 3/4] ci(gitlab,windows): fix Rust setup for GitLab's MinGW build

From
Patrick Steinhardt <ps@pks.im>
Date
Sep 28, 2026, 06:50 UTC
Message-ID
<aroOJHlxCs9Rnwv-@pks.im>
In-Reply-To
<1c829af9-1923-a6ff-78a1-b738cc6bf5a6@gmx.de>
On Thu, Sep 24, 2026 at 09:55:53PM +0200, Johannes Schindelin wrote:
Show 22 quoted lines
> Hi Patrick,
> 
> On Thu, 24 Sep 2026, Patrick Steinhardt wrote:
> 
> > On Sat, Sep 19, 2026 at 12:12:12PM +0000, Johannes Schindelin via GitGitGadget wrote:
> > > diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
> > > index cd6fd4a504..3f24835500 100644
> > > --- a/.gitlab-ci.yml
> > > +++ b/.gitlab-ci.yml
> > > @@ -133,8 +133,11 @@ build:mingw64:
> > >    before_script:
> > >      - *windows_before_script
> > >      - ./ci/install-sdk.ps1 -directory "git-sdk"
> > > +    - ./ci/install-dependencies.ps1 -Mingw
> > 
> > I wonder whether it would now make sense to also hoist "install-sdk.ps1"
> > into "install-dependencies.ps1" now.
> 
> Honestly, I wouldn't. It is conceptually a different thing, the SDK brings
> a ready-configured environment (which _partially_ ships dependencies,
> that's right, but it's a Venn diagram, not a strict super set
> relationship).
Fair enough.
Show 22 quoted lines
> > >    script:
> > > -    - git-sdk/usr/bin/bash.exe -l -c 'ci/make-test-artifacts.sh artifacts'
> > > +    # The minimal SDK's profile resets PATH.
> > > +    - git-sdk/usr/bin/bash.exe -l -c
> > > +        'PATH=$PATH:/c/Rust/bin ci/make-test-artifacts.sh artifacts'
> > 
> > Are we sure that PATH cannot ever contain spaces or should we rather
> > quote here?
> 
> Ah, quoting in shell, what a wonderfully magical world. While you would be
> correct that passing an unquoted `$PATH` as an _argument_ would cause
> unwanted misinterpretation as multiple arguments instead of a single one,
> _assigning variables_ is a completely different issue. Observe:
> 
>   $ x="Patrick Steinhardt"; x=$x=hello env | grep ^x=
>   x=Patrick Steinhardt=hello
> 
> Wha...? It did _not_ split the $x at whitespace? No. In what must have
> occurred as quite logical to the inventors of the Unix shell syntax,
> interpolating unquoted variables in assignments does *not* split at
> whitespace, unlike in other instances where unquoted variables are very
> much split at whitespace.
Well, TIL :)
Patrick
Previous: Johannes SchindelinNext: Junio C Hamano
Message 10 of 27 in “gitlab-ci: fix the cargo invocation in the Windows job”
  1. 0/4 gitlab-ci: fix the cargo invocation in the Windows jobJohannes Schindelin via GitGitGadget, Sep 19, 2026
  2. 1/4 ci(gitlab,windows): provision GNU Rust for SDK-based MinGW buildsJohannes Schindelin via GitGitGadget, Sep 19, 2026
  3. Patrick SteinhardtSep 24, 2026
  4. Johannes SchindelinSep 24, 2026
  5. 2/4 ci(gitlab,windows): preserve exclusions during dependency setupJohannes Schindelin via GitGitGadget, Sep 19, 2026
  6. Patrick SteinhardtSep 24, 2026
  7. 3/4 ci(gitlab,windows): fix Rust setup for GitLab's MinGW buildJohannes Schindelin via GitGitGadget, Sep 19, 2026
  8. Patrick SteinhardtSep 24, 2026
  9. Johannes SchindelinSep 24, 2026
  10. Patrick SteinhardtSep 28, 2026
  11. Junio C HamanoSep 28, 2026
  12. 4/4 ci(gitlab,windows): provide GNU Rust's host-linker supportJohannes Schindelin via GitGitGadget, Sep 19, 2026
  13. Patrick SteinhardtSep 24, 2026
  14. Johannes SchindelinSep 24, 2026
  15. Karthik NayakSep 19, 2026
  16. Johannes SchindelinSep 20, 2026
  17. Karthik NayakSep 21, 2026
  18. Johannes SchindelinSep 22, 2026
  19. Karthik NayakSep 23, 2026
  20. 0/4 gitlab-ci: fix the cargo invocation in the Windows jobJohannes Schindelin via GitGitGadget, Sep 24, 2026
  21. 1/4 ci(gitlab,windows): provision GNU Rust for SDK-based MinGW buildsJohannes Schindelin via GitGitGadget, Sep 24, 2026
  22. 2/4 ci(gitlab,windows): preserve exclusions during dependency setupJohannes Schindelin via GitGitGadget, Sep 24, 2026
  23. 3/4 ci(gitlab,windows): fix Rust setup for GitLab's MinGW buildJohannes Schindelin via GitGitGadget, Sep 24, 2026
  24. 4/4 ci(gitlab,windows): provide GNU Rust's host-linker supportJohannes Schindelin via GitGitGadget, Sep 24, 2026
  25. Patrick SteinhardtSep 28, 2026
  26. Johannes SchindelinSep 28, 2026
  27. Junio C HamanoSep 28, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.