git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v8 0/4] tag: configure default tag sort via .gitconfig

From
Junio C Hamano <gitster@pobox.com>
Date
Jul 15, 2014, 22:40 UTC
Message-ID
<xmqqbnsqtfdb.fsf@gitster.dls.corp.google.com>
In-Reply-To
<1405459754-4220-1-git-send-email-jacob.e.keller@intel.com>
Jacob Keller <jacob.e.keller@intel.com> writes:
Show 16 quoted lines
> This patch series is hopefully the final version of a series of patches which
> updates git-tag to allow the .gitconfig variable 'tag.sort' to be used as the
> default sort parameter. This version uses a new set/pop error routine setup
> which enables correctly modifying the error routine to handle the config vs the
> command line.
>
> In addition, I split the patch such that all the changes to the original
> parse_opt_sort are shown, and the following patch which extracts this function
> is just a function extraction with no changes, making it easier to review the
> new changes. One other minor bug fix is included as well.
>
> Jacob Keller (4):
>   usage: make error functions a stack
>   tag: fix --sort tests to use cat<<-\EOF format
>   tag: update parsing to be more precise regarding errors
>   tag: support configuring --sort via .gitconfig

The first one looked somewhat tricky, but looked nice overall from a cursory reading.

Thanks.
Previous: Jacob Keller
Message 11 of 11 in “tag: configure default tag sort via .gitconfig”
  1. 0/4 tag: configure default tag sort via .gitconfigJacob Keller, Jul 15, 2014
  2. 1/4 usage: make error functions a stackJacob Keller, Jul 15, 2014
  3. Junio C HamanoJul 15, 2014
  4. Keller, Jacob EJul 15, 2014
  5. Keller, Jacob EJul 15, 2014
  6. Junio C HamanoJul 16, 2014
  7. Keller, Jacob EJul 16, 2014
  8. 2/4 tag: fix --sort tests to use cat<<-\EOF formatJacob Keller, Jul 15, 2014
  9. 3/4 tag: update parsing to be more precise regarding errorsJacob Keller, Jul 15, 2014
  10. 4/4 tag: support configuring --sort via .gitconfigJacob Keller, Jul 15, 2014
  11. Junio C HamanoJul 15, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.