From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 15 Jul 2014 22:40:48 GMT
Subject: Re: [PATCH v8 0/4] tag: configure default tag sort via .gitconfig
Message-ID: <xmqqbnsqtfdb.fsf@gitster.dls.corp.google.com>
In-Reply-To: <1405459754-4220-1-git-send-email-jacob.e.keller@intel.com>

Jacob Keller <jacob.e.keller@intel.com> writes:

> This patch series is hopefully the final version of a series of patches which
> updates git-tag to allow the .gitconfig variable 'tag.sort' to be used as the
> default sort parameter. This version uses a new set/pop error routine setup
> which enables correctly modifying the error routine to handle the config vs the
> command line.
>
> In addition, I split the patch such that all the changes to the original
> parse_opt_sort are shown, and the following patch which extracts this function
> is just a function extraction with no changes, making it easier to review the
> new changes. One other minor bug fix is included as well.
>
> Jacob Keller (4):
>   usage: make error functions a stack
>   tag: fix --sort tests to use cat<<-\EOF format
>   tag: update parsing to be more precise regarding errors
>   tag: support configuring --sort via .gitconfig

The first one looked somewhat tricky, but looked nice overall from a
cursory reading.

Thanks.