Re: [PATCH v8 1/4] usage: make error functions a stack

From: Keller, Jacob E <jacob.e.keller@intel.com>
Date: Jul 15, 2014, 23:26 UTC
Message-ID: <1405466783.2577.15.camel@jekeller-desk1.amr.corp.intel.com>
In-Reply-To: <xmqq7g3etf1o.fsf@gitster.dls.corp.google.com>

On Tue, 2014-07-15 at 15:47 -0700, Junio C Hamano wrote:

Show 10 quoted lines

> Jacob Keller <jacob.e.keller@intel.com> writes:
> 
> >  extern void set_error_routine(void (*routine)(const char *err, va_list params));
> > +extern void pop_error_routine(void);
> 
> pop that undoes set smells somewhat weird.  Perhaps we should rename
> set to push?  That would allow us catch possible topics that add new
> calls to set_error_routine() as well by forcing the system not to
> link when they are merged without necessary fixes.
>

Also curious what your thoughts on making every set_*_routine to be a stack? For now I was only planning on error but it maybe makes sense to change them all?

Thanks, Jake