Re: [PATCH] reset cached ident date before creating objects

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 1, 2016, 17:49 UTC
Message-ID: <xmqqbn1cl6qv.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <20160730024135.oaqtjpo5l2e3dam2@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 7 quoted lines

>> So maybe we would have to put reset_ident_date() at the end of the
>> function instead, at least after git_committer_info() is called.
>
> Yes, although "reset and end" still feels a bit weird to me.
>
> I'd almost prefer to just have long-running programs insert resets at
> strategic points.

Certainly "reset at the end" feels weird but it can be explained as "for a one-shot thing we use the first time of the default date and it gives a consistent timestamp; conceptually, things that make multiple commits are like doing that one-shot thing multiple times in a row."

When viewed that way, it is not _too_ bad, I would guess.