Re: Small trivial annoyance with the nice new builtin "git am"

From: Junio C Hamano <gitster@pobox.com>
Date: Jul 28, 2016, 23:47 UTC
Message-ID: <CAPc5daX=MoqEXkV7DdpT+J=4K_qNdo0aNu_XgUs+9yggyrMXbQ@mail.gmail.com>
In-Reply-To: <CA+55aFxaia7_VkKKF3JiQt76+z5goz3vCpmWi-wTyBH=iaw5ew@mail.gmail.com>

On Thu, Jul 28, 2016 at 4:35 PM, Linus Torvalds <torvalds@linux-foundation.org> wrote:

Show 9 quoted lines

> Ok, it's no longer *that* new, but I only now noticed..
>
> So I noticed that when I applied the last patch-bomb series from
> Andrew, all the commit date-stamps are idential.
> ...
> That seems entirely accidental, I think that what happened is that
> "ident_default_date()" just ends up initializing the default date
> string once, and then the date is cached there, because it's now run
> as a single process for the whole series.

Ouch, sorry, that certainly sounds utterly broken. I have a suspicion that we would see more and more breakages like this in the near future, as there are folks trying to redo multi-commit commands in a single process. We need to be very careful to avoid the same mistake.

Also makes me wonder if "git cherry-pick A..B" shares the same breakage.

Thanks.