Re: Small trivial annoyance with the nice new builtin "git am"
- From
Linus Torvalds <torvalds@linux-foundation.org>
- Date
- Jul 29, 2016, 00:37 UTC
- Message-ID
- <CA+55aFzRBQNU80ukcAk2JjbeWTvo8jHxejBeWWPjrHHuX7ygSQ@mail.gmail.com>
- In-Reply-To
- <20160729002902.GD9646@sigill.intra.peff.net>
On Thu, Jul 28, 2016 at 5:29 PM, Jeff King <peff@peff.net> wrote:
Show 7 quoted lines
>
> I guess we want something like:
>
> +void reset_ident_date(void)
> +{
> + strbuf_reset(&git_default_date);
> +}Looks sane.
> and then to sprinkle calls liberally through builtin-ified programs when > they move from one unit of work to the next.
Maybe we can just add it to the end of commit_tree_extended(), and just say "the cache is reset between commits".
That way there is no sprinking in random places.
Linus