Re: [PATCH] fixup! log: add exhaustive tests for pattern style options & config

From: Junio C Hamano <gitster@pobox.com>
Date: May 15, 2017, 02:18 UTC
Message-ID: <xmqqbmquyiae.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <CACBZZX7MXh_9mG1EROZVEEGapBwjzRWzr3S57f6rWLnQe9L+XA@mail.gmail.com>

Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:

Show 6 quoted lines

> Thanks for the hotfix. I'll fix this in my v2, but do it differently
> in such a way that I can still run these tests on windows.
>
> I.e. the actual test here just needs these odd characters in the
> commit message. It's just an unintended implementation detail of
> test_commit that a tag is being created.

My knee-jerk reaction matched Dscho's, but grep is about contents, and we should be able to test this if we used a sensible tagnames or didn't use any. Glad to see somebody can step back and think ;-)