Re: [PATCH] fixup! log: add exhaustive tests for pattern style options & config

From: Jonathan Nieder <jrnieder@gmail.com>
Date: May 12, 2017, 23:44 UTC
Message-ID: <20170512234414.GF27400@aiede.svl.corp.google.com>
In-Reply-To: <92c10618c688bb8cb1f31ee2a93110c581974468.1494586245.git.johannes.schindelin@gmx.de>

Johannes Schindelin wrote:

Show 7 quoted lines

> On Windows, `(1|2)` is not a valid file name, and therefore the tag
> cannot be created as expected by the new test.
>
> So simply skip this test on Windows.
>
> Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
> ---

Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>

I wouldn't be surprised if there are filesystems used places other than MINGW that also can't handle this test. Isn't this what some tests use a FUNNYNAMES prerequisite for?

In this example, it's the pipe that's not allowed, not the parenthesis, right? (At least I have some memories of naming files with some parentheses.) Would something like

	test PIPE_IN_FILENAME '
		>"a|b" &&
		test -f "a|b"
	'

work?

Thanks, Jonathan