git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] fixup! log: add exhaustive tests for pattern style options & config

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
May 15, 2017, 12:19 UTC
Message-ID
<alpine.DEB.2.21.1.1705151418000.146734@virtualbox>
In-Reply-To
<xmqqbmquyiae.fsf@gitster.mtv.corp.google.com>
Hi Junio,
On Mon, 15 May 2017, Junio C Hamano wrote:
Show 12 quoted lines
> Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:
> 
> > Thanks for the hotfix. I'll fix this in my v2, but do it differently
> > in such a way that I can still run these tests on windows.
> >
> > I.e. the actual test here just needs these odd characters in the
> > commit message. It's just an unintended implementation detail of
> > test_commit that a tag is being created.
> 
> My knee-jerk reaction matched Dscho's, but grep is about contents,
> and we should be able to test this if we used a sensible tagnames or
> didn't use any.  Glad to see somebody can step back and think ;-)

Maybe somebody should step back even further and think even more, as we could adjust test_commit to mangle the argument into a tag name that is legal even with a refs backend relying on NTFS.

Ciao, Dscho

Previous: Junio C HamanoNext: Junio C Hamano
Message 9 of 11 in “fixup! log: add exhaustive tests for pattern style options & config”
  1. fixup! log: add exhaustive tests for pattern style options & configJohannes Schindelin, May 12, 2017
  2. Junio C HamanoMay 12, 2017
  3. Jonathan NiederMay 12, 2017
  4. Ævar Arnfjörð BjarmasonMay 13, 2017
  5. Johannes SchindelinMay 13, 2017
  6. Jonathan NiederMay 15, 2017
  7. Ævar Arnfjörð BjarmasonMay 13, 2017
  8. Junio C HamanoMay 15, 2017
  9. Johannes SchindelinMay 15, 2017
  10. Junio C HamanoMay 16, 2017
  11. Ævar Arnfjörð BjarmasonMay 16, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.