Re: [PATCH v2 0/9] Teach 'run' perf script to read config files

From: Junio C Hamano <gitster@pobox.com>
Date: Sep 24, 2017, 07:59 UTC
Message-ID: <xmqqbmm0h6h1.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <CAP8UFD2j-UFh+9awz91gtZ-jusq7EUOExMgURO59vpf29jXS4A@mail.gmail.com>

Christian Couder <christian.couder@gmail.com> writes:

> (It looks like smtp.gmail.com isn't working anymore for me, so I am
> trying to send this using Gmail for the cover letter and Submitgit for
> the patches.)

SubmitGit may want to learn the "change the timestamps of the individual patches by 1 second" trick from "git send-email" to help threading (you can view inbox/comp.version-control.git/ group over nntp and tell your newsreader to sort-by-date).

> Highlevel view of the patches in the series
> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
>   - Patches 1/9 to 4/9 were already in v1 and haven't changed.

It isn't quite clear what _did_ change in the series and what lessons were learned form the previous round's discussion here. The sample configuration in the description above (snipped) seems to have been extended and it shows that one of the use cases of the feature is to allow comparing runs against two versions, which looked more or less sensible way to express it.

Show 15 quoted lines

> Christian Couder (9):
>   perf/run: add '--config' option to the 'run' script
>   perf/run: add get_var_from_env_or_config()
>   perf/run: add GIT_PERF_DIRS_OR_REVS
>   perf/run: add calls to get_var_from_env_or_config()
>   perf/run: add get_subsections()
>   perf/run: update get_var_from_env_or_config() for subsections
>   perf/run: add run_subsection()
>   perf/run: show name of rev being built
>   perf: store subsection results in "test-results/$GIT_PERF_SUBSECTION/"
>
>  t/perf/aggregate.perl | 11 +++++--
>  t/perf/perf-lib.sh    |  4 +--
>  t/perf/run            | 89 +++++++++++++++++++++++++++++++++++++++++++++------
>  3 files changed, 89 insertions(+), 15 deletions(-)

Thanks.  Let me see how well it works ;-)