Re: [PATCH v2 0/9] Teach 'run' perf script to read config files

From: Christian Couder <christian.couder@gmail.com>
Date: Sep 26, 2017, 15:40 UTC
Message-ID: <CAP8UFD1C80cHnMtdZ-iTYQpNNErUEJ9TmQ9baG1J2w+pv1ceSw@mail.gmail.com>
In-Reply-To: <xmqqbmm0h6h1.fsf@gitster.mtv.corp.google.com>

On Sun, Sep 24, 2017 at 9:59 AM, Junio C Hamano <gitster@pobox.com> wrote:

Show 10 quoted lines

> Christian Couder <christian.couder@gmail.com> writes:
>
>> (It looks like smtp.gmail.com isn't working anymore for me, so I am
>> trying to send this using Gmail for the cover letter and Submitgit for
>> the patches.)
>
> SubmitGit may want to learn the "change the timestamps of the
> individual patches by 1 second" trick from "git send-email" to help
> threading (you can view inbox/comp.version-control.git/ group over
> nntp and tell your newsreader to sort-by-date).

Roberto is now in CC. I will let him answer about that.

Show 7 quoted lines

>> Highlevel view of the patches in the series
>> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>>
>>   - Patches 1/9 to 4/9 were already in v1 and haven't changed.
>
> It isn't quite clear what _did_ change in the series and what
> lessons were learned form the previous round's discussion here.

In the previous round of discussion, I think the reviewers (you and Peff) basically agreed that it was worth improving the test framework to make it possible to easily run many tests, though reviewers were not sure if what I had planned to do would in the end be a good solution.

(See https://public-inbox.org/git/20170713065050.19215-1-chriscool@tuxfamily.org/)

So what did change is that I implemented what was in the "Future work" section in v1.

Show 5 quoted lines

> The
> sample configuration in the description above (snipped) seems to
> have been extended and it shows that one of the use cases of the
> feature is to allow comparing runs against two versions, which
> looked more or less sensible way to express it.

[...]

> Thanks.  Let me see how well it works ;-)

Thanks for testing ;-)