Re: [PATCH v2 0/9] Teach 'run' perf script to read config files
- From
Roberto Tyley <roberto.tyley@gmail.com>
- Date
- Sep 26, 2017, 19:33 UTC
- Message-ID
- <CAFY1edZ6FX6s+H_XWa-=nKqr4NA9BNVxR6fcOo+5gn-Z1XKdUg@mail.gmail.com>
- In-Reply-To
- <CAP8UFD1C80cHnMtdZ-iTYQpNNErUEJ9TmQ9baG1J2w+pv1ceSw@mail.gmail.com>
On 26 September 2017 at 16:40, Christian Couder <christian.couder@gmail.com> wrote:
Show 13 quoted lines
> On Sun, Sep 24, 2017 at 9:59 AM, Junio C Hamano <gitster@pobox.com> wrote: >> Christian Couder <christian.couder@gmail.com> writes: >> >>> (It looks like smtp.gmail.com isn't working anymore for me, so I am >>> trying to send this using Gmail for the cover letter and Submitgit for >>> the patches.) >> >> SubmitGit may want to learn the "change the timestamps of the >> individual patches by 1 second" trick from "git send-email" to help >> threading (you can view inbox/comp.version-control.git/ group over >> nntp and tell your newsreader to sort-by-date). > > Roberto is now in CC. I will let him answer about that.
I had a quick look at git-send-email.perl, I see the trick is the `time++` one introduced with https://github.com/git/git/commit/a5370b16 - seems reasonable!
SubmitGit makes all emails in-reply-to the initial email, which I think is correct behaviour, but I can see that offsetting the times would probably give a more reliable sorting in a newsreader. Unfortunately the documentation for AWS Simple Email Service (SES) says:
"Note: Amazon SES overrides any Date header you provide with the time that Amazon SES accepts the message."
http://docs.aws.amazon.com/ses/latest/DeveloperGuide/header-fields.html
...so the only way SubmitGit can offset the times is to literally delay the sending of the emails, which is a bit unfortunate for patchbombs more than a few dozen commits long!
I'll take a further look at this when I get a bit more free time.
Roberto