git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v3 [re-fixed] ] [Enhancement] Improve internals / refactoring.

From
Junio C Hamano <gitster@pobox.com>
Date
Feb 4, 2019, 17:56 UTC
Message-ID
<xmqqbm3rwi7t.fsf@gitster-ct.c.googlers.com>
In-Reply-To
<01020168b080030b-eb0a0634-f2b9-42ed-a3be-76995e7127eb-000000@eu-west-1.amazonses.com>
Shahzad Lone <shahzadlone@gmail.com> writes:
> Subject: Re: [PATCH v3 [re-fixed] ] [Enhancement] Improve internals / refactoring.

Since all patches are attempts by their authors to improve something, the above has a very low information density. As all the changes in this patch are about const-ness, it would probably be a good idea to sneak that word into the title---that way, when placed among many changes, a reader would be able to still recognize what this change is about in "git shortlog --no-merges" output.

Perhaps
        Subject: [PATCH v3] tighten constness
or something?
Previous: Shahzad Lone
Message 9 of 9 in “[Enhancement] Improve internals / refactoring.”
  1. 1/3 [Enhancement] Improve internals / refactoring.Shahzad Lone, Feb 1, 2019
  2. 3/3 It's C not C++ so variable length array should not be used [-Werror=vla] :,).Shahzad Lone, Feb 1, 2019
  3. Eric SunshineFeb 1, 2019
  4. 2/3 ISO C90 forbids mixed declarations and code [-Werror=declaration-after-statement] so fix that.Shahzad Lone, Feb 1, 2019
  5. Eric SunshineFeb 1, 2019
  6. ] [Enhancement] Improve internals / refactoring.Shahzad Lone, Feb 1, 2019
  7. Brandon RichardsonFeb 2, 2019
  8. ] [Enhancement] Improve internals / refactoring.Shahzad Lone, Feb 2, 2019
  9. Junio C HamanoFeb 4, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.