Re: [PATCH v2 [rebased]] [Enhancement] Improve internals / refactoring.

From: Brandon Richardson <brandon1024.br@gmail.com>
Date: Feb 2, 2019, 03:09 UTC
Message-ID: <CAETBDP7jw_z_Nz7X-+jne7sYrJ7G92wWsB3S_ipf3XjJwxYxfw@mail.gmail.com>
In-Reply-To: <01020168ab79f642-10a06c5b-c3f7-441e-86f8-bff5e41ac834-000000@eu-west-1.amazonses.com>

Hi Shahzad,

On Fri, 1 Feb 2019 at 19:54, Shahzad Lone <shahzadlone@gmail.com> wrote:

Show 6 quoted lines

>         git_zstream stream;
> -       unsigned char ibuf[1024 * 16];
> -       unsigned char obuf[1024 * 16];
> +       unsigned char ibuf[16384];
> +       unsigned char obuf[16384];
>         unsigned long olen = 0;

This change also brings very little value because most compilers will evaluate constant expressions such as this at compile time. A quick google query on "Constant Folding" will tell you all about this.

I love optimization as much as the next guy, but I also feel an argument can be made for readability too. The former version is far easier to see that the array will be 16KB in size, where 16384 is more difficult to visualize.