git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 2/3] ISO C90 forbids mixed declarations and code [-Werror=declaration-after-statement] so fix that.

From
Shahzad Lone <shahzadlone@gmail.com>
Date
Feb 1, 2019, 08:36 UTC
Message-ID
<01020168a83380fb-ecad8400-915d-497c-841f-096541747cd6-000000@eu-west-1.amazonses.com>
In-Reply-To
<01020168a8338064-b1c054c4-3e05-4825-b8dc-636d9c63dcfc-000000@eu-west-1.amazonses.com>
---
 pack-revindex.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/pack-revindex.c b/pack-revindex.c
index 202981b39c6b6..40651ec9fac2e 100644
--- a/pack-revindex.c
+++ b/pack-revindex.c
@@ -186,9 +186,9 @@ int find_revindex_position(struct packed_git *p, off_t ofs)
 
 struct revindex_entry *find_pack_revindex(struct packed_git *p, off_t ofs)
 {
-
+	int pos;
 	load_pack_revindex(p);
-	const int pos = find_revindex_position(p, ofs);
+	pos = find_revindex_position(p, ofs);
 
 	if (pos < 0)
 		return NULL;

--
https://github.com/git/git/pull/572
Previous: Eric SunshineNext: Eric Sunshine
Message 4 of 9 in “[Enhancement] Improve internals / refactoring.”
  1. 1/3 [Enhancement] Improve internals / refactoring.Shahzad Lone, Feb 1, 2019
  2. 3/3 It's C not C++ so variable length array should not be used [-Werror=vla] :,).Shahzad Lone, Feb 1, 2019
  3. Eric SunshineFeb 1, 2019
  4. 2/3 ISO C90 forbids mixed declarations and code [-Werror=declaration-after-statement] so fix that.Shahzad Lone, Feb 1, 2019
  5. Eric SunshineFeb 1, 2019
  6. ] [Enhancement] Improve internals / refactoring.Shahzad Lone, Feb 1, 2019
  7. Brandon RichardsonFeb 2, 2019
  8. ] [Enhancement] Improve internals / refactoring.Shahzad Lone, Feb 2, 2019
  9. Junio C HamanoFeb 4, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.