Re: [PATCH 1/3] graph: fix case that hit assert()
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jan 7, 2020, 19:21 UTC
- Message-ID
- <xmqqblrf5azn.fsf@gitster-ct.c.googlers.com>
- In-Reply-To
- <20200107153006.GA20591@coredump.intra.peff.net>
Jeff King <peff@peff.net> writes:
Show 8 quoted lines
>> Second, the horizontal lines in that first line drop their coloring. >> This is due to a use of graph_line_addch() instead of >> graph_line_write_column(). Using a ternary operator to pick the >> character is nice for compact code, but we actually need a column >> to provide the color. > > It seems like this is a totally separate bug, and could be its own > commit?
I think so.
And with that removed, all that remains would be a removal of the assert() plus an additional test?
Show 5 quoted lines
>> +test_expect_success 'log --graph with multiple tips' ' > > This nicely covers the assert() problem. Could we check the same case > with "--color" and test_decode_color to check the coloring issue (see > t4214 for some prior art)?