Re: [PATCH 3/3] t4215: add bigger graph collapse test
- From
Jeff King <peff@peff.net>
- Date
- Jan 7, 2020, 18:04 UTC
- Message-ID
- <20200107180415.GB48806@coredump.intra.peff.net>
- In-Reply-To
- <xmqqftgr5elz.fsf@gitster-ct.c.googlers.com>
On Tue, Jan 07, 2020 at 10:02:48AM -0800, Junio C Hamano wrote:
Show 25 quoted lines
> Jeff King <peff@peff.net> writes: > > > On Tue, Jan 07, 2020 at 02:55:47PM +0000, Derrick Stolee via GitGitGadget wrote: > > > >> From: Derrick Stolee <dstolee@microsoft.com> > >> > >> A previous test in t4215-log-skewed-merges.sh was added to demonstrate > >> exactly the topology of a reported failure in "git log --graph". While > >> investigating the fix, we realized that multiple edges that could > >> collapse with horizontal lines were not doing so. > > > > Thanks for constructing this larger case. > > > > As for including this patch, I could take or leave it for now. I like > > the idea of documenting things further, but unless it's marked > > expect_failure, I don't think it's going to call anybody's attention > > more than this thread already has. > > > > So I'd love to hear what James thinks should happen here, given that > > it's an extension of his other work. But I'd just as soon punt on the > > patch until we decide whether it _should_ change (and then either mark > > it with expect_failure, or include the test along with a patch changing > > the behavior). > > ... and nobody CC'ed the person from whom they want to hear opinion?
Doh, thank you. :) I cc'd him in the earlier thread, but GGG creates a new one.
-Peff