Re: [PATCH 3/3] t4215: add bigger graph collapse test

From: Jeff King <peff@peff.net>
Date: Jan 7, 2020, 15:39 UTC
Message-ID: <20200107153922.GC20591@coredump.intra.peff.net>
In-Reply-To: <f74e82bea68701beb734537cafd147162d1bb2c6.1578408947.git.gitgitgadget@gmail.com>

On Tue, Jan 07, 2020 at 02:55:47PM +0000, Derrick Stolee via GitGitGadget wrote:

Show 6 quoted lines

> From: Derrick Stolee <dstolee@microsoft.com>
> 
> A previous test in t4215-log-skewed-merges.sh was added to demonstrate
> exactly the topology of a reported failure in "git log --graph". While
> investigating the fix, we realized that multiple edges that could
> collapse with horizontal lines were not doing so.

Thanks for constructing this larger case.

As for including this patch, I could take or leave it for now. I like the idea of documenting things further, but unless it's marked expect_failure, I don't think it's going to call anybody's attention more than this thread already has.

So I'd love to hear what James thinks should happen here, given that it's an extension of his other work. But I'd just as soon punt on the patch until we decide whether it _should_ change (and then either mark it with expect_failure, or include the test along with a patch changing the behavior).

-Peff