Re: [PATCH] ident: say whose identity is missing when giving user.name hint

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 21, 2020, 22:35 UTC
Message-ID: <xmqqblj37hlv.fsf@gitster.c.googlers.com>
In-Reply-To: <CAPig+cSLxRVufZcnXa6JAbP-SYX486OebDS5hYjEhH7jaNgM5Q@mail.gmail.com>

Eric Sunshine <sunshine@sunshineco.com> writes:

Show 5 quoted lines

> On Fri, Aug 21, 2020 at 5:31 PM Alvaro Aleman <aaleman@redhat.com> wrote:
>> One nit though: There is no `--committer` flag for `git commit`,
>
> Indeed, that `--committer=` was a last-second edit (without checking
> docs).

Yeah, I forgot that we deliberately omit the command line option for the committer info.

Show 14 quoted lines

> How about this?
>
>     If `user.name` and `user.email` have not been configured and the
>     user invokes:
>
>         git commit --author=...
>
>     without specifying the committer, then Git errors out with a
>     message asking the user to configure `user.name` and `user.email`
>     but doesn't tell the user which attribution was missing. This can
>     be confusing for a user new to Git who isn't aware of the
>     distinction between user, author, and committer.  Give such users
>     a bit more help by extending the error message to also say which
>     attribution is expected.

OK.