Re: [PATCH] ident: say whose identity is missing when giving user.name hint

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Aug 21, 2020, 21:37 UTC
Message-ID: <CAPig+cSLxRVufZcnXa6JAbP-SYX486OebDS5hYjEhH7jaNgM5Q@mail.gmail.com>
In-Reply-To: <CAOW=8D1nFgRRPyD7yxW2X7ZcAA3yaMzWJy7B3ykuPBJk3t8X5Q@mail.gmail.com>

On Fri, Aug 21, 2020 at 5:31 PM Alvaro Aleman <aaleman@redhat.com> wrote:

> One nit though: There is no `--committer` flag for `git commit`,

Indeed, that `--committer=` was a last-second edit (without checking docs). How about this?

    If `user.name` and `user.email` have not been configured and the
    user invokes:

        git commit --author=...

    without specifying the committer, then Git errors out with a
    message asking the user to configure `user.name` and `user.email`
    but doesn't tell the user which attribution was missing. This can
    be confusing for a user new to Git who isn't aware of the
    distinction between user, author, and committer.  Give such users
    a bit more help by extending the error message to also say which
    attribution is expected.