Re: [PATCH] ident: say whose identity is missing when giving user.name hint

From: Alvaro Aleman <aaleman@redhat.com>
Date: Aug 21, 2020, 21:31 UTC
Message-ID: <CAOW=8D1nFgRRPyD7yxW2X7ZcAA3yaMzWJy7B3ykuPBJk3t8X5Q@mail.gmail.com>
In-Reply-To: <xmqq1rjz8zy7.fsf@gitster.c.googlers.com>

One nit though: There is no `--committer` flag for `git commit`, unless this has changed after the v2.28.0 release:

``` $ g commit -m message --committer someone@somemail.com error: unknown option `committer' $ git --version git version 2.28.0 ```

On Fri, Aug 21, 2020 at 5:13 PM Junio C Hamano <gitster@pobox.com> wrote:

Show 18 quoted lines

>
> Eric Sunshine <sunshine@sunshineco.com> writes:
>
> >     If `user.name` and `user.email` have not been configured and the
> >     user invokes:
> >
> >         git commit --author=...
> >
> >     without without specifying `--committer=`, then Git errors out
> >     with a message asking the user to configure `user.name` and
> >     `user.email` but doesn't tell the user which attribution was
> >     missing. This can be confusing for a user new to Git who isn't
> >     aware of the distinction between user, author, and committer.
> >     Give such users a bit more help by extending the error message to
> >     also say which attribution is expected.
>
> Much easier to read.  Will steal.
>