Re: [PATCH 2/3] ls-remote: remove documentation for custom -h option

From: Junio C Hamano <gitster@pobox.com>
Date: Sep 24, 2021, 18:17 UTC
Message-ID: <xmqqbl4hvnxa.fsf@gitster.g>
In-Reply-To: <20210924171113.GA3311029@szeder.dev>

SZEDER Gábor <szeder.dev@gmail.com> writes:

Show 13 quoted lines

> On Fri, Sep 24, 2021 at 06:51:45PM +0200, Ævar Arnfjörð Bjarmason wrote:
>> The custom handling of the "-h" option was broken in
>> ba5f28bf79e (ls-remote: use parse-options api, 2016-01-19), first
>> released with Git v2.8.0. We've been promising that it's a synonym of
>> --head, but it's not.
>> 
>> We could make this work again by supplying the
>> PARSE_OPT_NO_INTERNAL_HELP flag to parse_options(), but if we were
>> writing this command today we wouldn't make this an exception. Since
>> it's been such a long time let's just remove this rather than
>> restoring the exception to "-h" handling.
>
> This breaks the case when '-h' is used in combination with a remote:

Yes, I think I covered this in my response to Ignacy. Perhaps Ævar can read it before rerolling this series.

Thanks.