git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/3] show-ref: remove unused custom handling of -h

From
Junio C Hamano <gitster@pobox.com>
Date
Sep 24, 2021, 19:24 UTC
Message-ID
<xmqq8rzlu697.fsf@gitster.g>
In-Reply-To
<patch-1.3-c79a3907a27-20210924T164820Z-avarab@gmail.com>
Ævar Arnfjörð Bjarmason  <avarab@gmail.com> writes:
Show 15 quoted lines
> Since b92891f9783 (parseopt: add PARSE_OPT_NO_INTERNAL_HELP,
> 2009-03-08) parse_options() has handled "-h" unless told not to, so
> when show-ref was migrated to parse_options() in
> 69932bc6117 (show-ref: migrate to parse-options, 2009-06-20) the
> custom "-h" handling that was retained did nothing.
>
> The option was then hidden in e62b3935056 (Show usage string for 'git
> show-ref -h', 2009-11-09), but that OPT_BOOLEAN didn't do
> anything. Let's just remove this dead code.
>
> Reported-by: Ignacy Gawedzki <ignacy.gawedzki@green-communications.fr>
> Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
> ---
>  builtin/show-ref.c | 2 --
>  1 file changed, 2 deletions(-)

While this is a fine no-op, I am not sure this "fixes" complaint in Ignacy's report. "git show-ref -h" would (and should) show the short-help, no?

Previous: Ævar Arnfjörð BjarmasonNext: René Scharfe
Message 4 of 12 in “Wrong option -h in grep, ls-remote, and show-ref.”
  1. Ignacy GawedzkiSep 24, 2021
  2. 0/3 show-ref, ls-remote, grep: fix -h handlingÆvar Arnfjörð Bjarmason, Sep 24, 2021
  3. 1/3 show-ref: remove unused custom handling of -hÆvar Arnfjörð Bjarmason, Sep 24, 2021
  4. Junio C HamanoSep 24, 2021
  5. René ScharfeSep 24, 2021
  6. Junio C HamanoSep 24, 2021
  7. 2/3 ls-remote: remove documentation for custom -h optionÆvar Arnfjörð Bjarmason, Sep 24, 2021
  8. SZEDER GáborSep 24, 2021
  9. Jeff KingSep 24, 2021
  10. Junio C HamanoSep 24, 2021
  11. 3/3 grep: pass PARSE_OPT_NO_INTERNAL_HELP, fix odd -h handlingÆvar Arnfjörð Bjarmason, Sep 24, 2021
  12. Junio C HamanoSep 24, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.