[PATCH 1/3] show-ref: remove unused custom handling of -h
- From
Ævar Arnfjörð Bjarmason <avarab@gmail.com>
- Date
- Sep 24, 2021, 16:51 UTC
- Message-ID
- <patch-1.3-c79a3907a27-20210924T164820Z-avarab@gmail.com>
- In-Reply-To
- <cover-0.3-00000000000-20210924T164820Z-avarab@gmail.com>
Since b92891f9783 (parseopt: add PARSE_OPT_NO_INTERNAL_HELP, 2009-03-08) parse_options() has handled "-h" unless told not to, so when show-ref was migrated to parse_options() in 69932bc6117 (show-ref: migrate to parse-options, 2009-06-20) the custom "-h" handling that was retained did nothing.
The option was then hidden in e62b3935056 (Show usage string for 'git show-ref -h', 2009-11-09), but that OPT_BOOLEAN didn't do anything. Let's just remove this dead code.
Reported-by: Ignacy Gawedzki <ignacy.gawedzki@green-communications.fr> Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com> --- builtin/show-ref.c | 2 -- 1 file changed, 2 deletions(-)
diff --git a/builtin/show-ref.c b/builtin/show-ref.c index 7f8a5332f83..8cefb663282 100644 --- a/builtin/show-ref.c +++ b/builtin/show-ref.c @@ -163,8 +163,6 @@ static const struct option show_ref_options[] = { OPT_BOOL(0, "heads", &heads_only, N_("only show heads (can be combined with tags)")), OPT_BOOL(0, "verify", &verify, N_("stricter reference checking, " "requires exact ref path")), - OPT_HIDDEN_BOOL('h', NULL, &show_head, - N_("show the HEAD reference, even if it would be filtered out")), OPT_BOOL(0, "head", &show_head, N_("show the HEAD reference, even if it would be filtered out")), OPT_BOOL('d', "dereference", &deref_tags,
-- 2.33.0.1285.g7aff81f6560