Re: [PATCH v2 4/3] clone: move unborn head creation to update_head()

From: Junio C Hamano <gitster@pobox.com>
Date: Jul 11, 2022, 20:36 UTC
Message-ID: <xmqqbktvo099.fsf@gitster.g>
In-Reply-To: <YsvrsOH1jg559yVt@coredump.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 5 quoted lines

> Let's move the creation of the unborn symref into update_head(). This
> matches the other HEAD-creation cases, and now the logic is consistently
> separated: the main cmd_clone() function only examines the situation and
> sets variables based on what it finds, and update_head() actually
> performs the update.

Yes, this step taken alone, and the final structure of the code, both look quite sensible.

Thanks, will queue on top.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.