[PATCH 1/3] clone: drop extra newline from warning message
- From
Jeff King <peff@peff.net>
- Date
- Jul 6, 2022, 08:00 UTC
- Message-ID
- <YsVBDK0CNLfWMgEG@coredump.intra.peff.net>
- In-Reply-To
- <YsVAfudoUA5YkQWH@coredump.intra.peff.net>
We don't need to put a "\n" in calls to warning(), since it adds one itself (and the user sees an extra blank line). Drop it, and while we're here, drop the full-stop from the message, which goes against our guidelines.
This bug dates all the way back to 8434c2f1af (Build in clone, 2008-04-27), but presumably nobody noticed because it's hard to trigger: you have to clone a repository whose HEAD is unborn, but which is not otherwise empty.
Signed-off-by: Jeff King <peff@peff.net> --- builtin/clone.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/builtin/clone.c b/builtin/clone.c index 89a91b0017..f596cedcf1 100644 --- a/builtin/clone.c +++ b/builtin/clone.c @@ -672,7 +672,7 @@ static int checkout(int submodule_progress, int filter_submodules) head = resolve_refdup("HEAD", RESOLVE_REF_READING, &oid, NULL); if (!head) { warning(_("remote HEAD refers to nonexistent ref, " - "unable to checkout.\n")); + "unable to checkout")); return 0; } if (!strcmp(head, "HEAD")) {
-- 2.37.0.408.g2817302ee7