Re: [PATCH] adjust_shared_perm(): leave g+s alone when the group does not matter

From: Junio C Hamano <gitster@pobox.com>
Date: Oct 28, 2022, 21:51 UTC
Message-ID: <xmqqbkpvhb0x.fsf@gitster.g>
In-Reply-To: <Y1xNrDB10XEcAa0d@tapette.crustytoothpaste.net>

"brian m. carlson" <sandals@crustytoothpaste.net> writes:

Show 10 quoted lines

> On 2022-10-28 at 21:16:09, Junio C Hamano wrote:
>> Julien Moutinho reports that in an environment where directory does
>> not have BSD group semantics and requires g+s (aka FORCE_DIR_SET_GID)
>> but the system cripples chmod() to forbid g+s, adjust_shared_perm()
>
> I would personally use a different verb here because I have the
> impression it's offensive, at least when used as a noun.  Perhaps
> "limit" or "restrict" might be more neutral, or we could pick another
> verb which expresses our displeasure at this design (maybe "impair"?)
> but maybe is less likely to be emotionally charged or offend.

castrates? butchers?

tweaks?  That's quite neutral.