git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] adjust_shared_perm(): leave g+s alone when the group does not matter

From
Junio C Hamano <gitster@pobox.com>
Date
Oct 28, 2022, 22:49 UTC
Message-ID
<xmqq5yg3ftri.fsf@gitster.g>
In-Reply-To
<Y1xWBiZUAbPmt71W@tapette.crustytoothpaste.net>
"brian m. carlson" <sandals@crustytoothpaste.net> writes:
Show 20 quoted lines
> On 2022-10-28 at 21:51:42, Junio C Hamano wrote:
>> "brian m. carlson" <sandals@crustytoothpaste.net> writes:
>> 
>> > On 2022-10-28 at 21:16:09, Junio C Hamano wrote:
>> >> Julien Moutinho reports that in an environment where directory does
>> >> not have BSD group semantics and requires g+s (aka FORCE_DIR_SET_GID)
>> >> but the system cripples chmod() to forbid g+s, adjust_shared_perm()
>> >
>> > I would personally use a different verb here because I have the
>> > impression it's offensive, at least when used as a noun.  Perhaps
>> > "limit" or "restrict" might be more neutral, or we could pick another
>> > verb which expresses our displeasure at this design (maybe "impair"?)
>> > but maybe is less likely to be emotionally charged or offend.
>> 
>> castrates? butchers?
>> 
>> tweaks?  That's quite neutral.
>
> I think "butchers" or "tweaks" should be fine.  I might say "modifies"
> as well.
I've decided to weaken it a lot by phrasing it like so:
    ... but the system forbids chmod() to touch the g+s bit, ...
Previous: brian m. carlson
Message 5 of 5 in “adjust_shared_perm(): leave g+s alone when the group does not matter”
  1. adjust_shared_perm(): leave g+s alone when the group does not matterJunio C Hamano, Oct 28, 2022
  2. brian m. carlsonOct 28, 2022
  3. Junio C HamanoOct 28, 2022
  4. brian m. carlsonOct 28, 2022
  5. Junio C HamanoOct 28, 2022

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.