Re: [PATCH] adjust_shared_perm(): leave g+s alone when the group does not matter
- From
brian m. carlson <sandals@crustytoothpaste.net>
- Date
- Oct 28, 2022, 22:21 UTC
- Message-ID
- <Y1xWBiZUAbPmt71W@tapette.crustytoothpaste.net>
- In-Reply-To
- <xmqqbkpvhb0x.fsf@gitster.g>
On 2022-10-28 at 21:51:42, Junio C Hamano wrote:
Show 16 quoted lines
> "brian m. carlson" <sandals@crustytoothpaste.net> writes: > > > On 2022-10-28 at 21:16:09, Junio C Hamano wrote: > >> Julien Moutinho reports that in an environment where directory does > >> not have BSD group semantics and requires g+s (aka FORCE_DIR_SET_GID) > >> but the system cripples chmod() to forbid g+s, adjust_shared_perm() > > > > I would personally use a different verb here because I have the > > impression it's offensive, at least when used as a noun. Perhaps > > "limit" or "restrict" might be more neutral, or we could pick another > > verb which expresses our displeasure at this design (maybe "impair"?) > > but maybe is less likely to be emotionally charged or offend. > > castrates? butchers? > > tweaks? That's quite neutral.
I think "butchers" or "tweaks" should be fine. I might say "modifies" as well.
-- brian m. carlson (he/him or they/them) Toronto, Ontario, CA