git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2] builtin/branch.c: adjust error messages to coding guidelines

From
Junio C Hamano <gitster@pobox.com>
Date
Oct 20, 2023, 17:10 UTC
Message-ID
<xmqqbkctrziu.fsf@gitster.g>
In-Reply-To
<CAP8UFD1U0cz3CDdE_0d0FUgPKP2pX-ZcVDJqz2tW-+rnZ7rvQw@mail.gmail.com>
Christian Couder <christian.couder@gmail.com> writes:
Show 5 quoted lines
>> Hello Junio, I would appreciate your comment on this.
>
> Please don't expect Junio to give direct feedback on all the patches
> sent to the mailing list. This patch has already been reviewed by
> Rubén.
Correct.
> If Junio doesn't review it and if this patch is not mentioned
> in the next "What's cooking in git.git" email from Junio, it likely
> means that you should send a version 3 addressing Rubén's feedback
> about the commit message.

While the above may be a good advice, I try to be easier to read than the above tealeaf-reading, especially to new contributors ;-)

At least I should comment on Rubén's comment, but I haven't got around to it yet.

Thanks.
Previous: Christian Couder
Message 12 of 12 in “branch.c: adjust error messages to coding guidelines”
  1. Isoken June IbizugbeOct 18, 2023
  2. Rubén JustoOct 18, 2023
  3. Junio C HamanoOct 18, 2023
  4. builtin/branch.c: adjust error messages to coding guidelinesIsoken June Ibizugbe, Oct 19, 2023
  5. Rubén JustoOct 19, 2023
  6. Junio C HamanoOct 20, 2023
  7. Isoken IbizugbeOct 20, 2023
  8. Rubén JustoOct 21, 2023
  9. Rubén JustoOct 21, 2023
  10. Isoken IbizugbeOct 20, 2023
  11. Christian CouderOct 20, 2023
  12. Junio C HamanoOct 20, 2023

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.