Re: [PATCH v2] builtin/branch.c: adjust error messages to coding guidelines

From: Rubén Justo <rjusto@gmail.com>
Date: Oct 21, 2023, 10:27 UTC
Message-ID: <c0d92716-2add-43c2-945a-cb0c9cb6b6a6@gmail.com>
In-Reply-To: <331e1ab3-2e8c-497d-a05d-ef197d664188@gmail.com>

On 19-oct-2023 21:20:24, Rubén Justo wrote:

> So, aside from the confusing message, this iteration looks good to me.

Reviewing again the messages in builtin/branch.c, if you finally re-roll, maybe you want to add:

diff --git a/builtin/branch.c b/builtin/branch.c
index e7ee9bd0f1..31da889e95 100644
--- a/builtin/branch.c
+++ b/builtin/branch.c
@@ -777,7 +777,7 @@ int cmd_branch(int argc, const char **argv, const char *prefix)
        if (!strcmp(head, "HEAD"))
                filter.detached = 1;
        else if (!skip_prefix(head, "refs/heads/", &head))
-               die(_("HEAD not found below refs/heads!"));
+               die(_("HEAD not found below refs/heads"));
 
But if you don't include this nit, that's fine with me.  I still think
the changes you've already made are correct.

Thank you.