Re: [Outreachy][PATCH] branch.c: adjust error messages to coding guidelines

From: Rubén Justo <rjusto@gmail.com>
Date: Oct 18, 2023, 18:19 UTC
Message-ID: <e08b2ec4-786a-4c18-b7af-0a6a250ae0f0@gmail.com>
In-Reply-To: <20231018051223.13955-1-isokenjune@gmail.com>

On 18-oct-2023 06:12:22, Isoken June Ibizugbe wrote:

> Signed-off-by: Isoken June Ibizugbe <isokenjune@gmail.com>
> ---
>  builtin/branch.c | 66 ++++++++++++++++++++++++------------------------
>  1 file changed, 33 insertions(+), 33 deletions(-)

Only builtin/branch.c is touched.

The changes in this patch break some tests, therefore this patch must also include the fixes for those tests.

Show 7 quoted lines

> @@ -965,11 +965,11 @@ int cmd_branch(int argc, const char **argv, const char *prefix)
>  		const char *start_name = argc == 2 ? argv[1] : head;
>  
>  		if (filter.kind != FILTER_REFS_BRANCHES)
> -			die(_("The -a, and -r, options to 'git branch' do not take a branch name.\n"
> +			die(_("the -a, and -r, options to 'git branch' do not take a branch name\n"
>  				  "Did you mean to use: -a|-r --list <pattern>?"));

OK. The initial 'T' is fixed, but as Junio explained [1], the full stop must stay.

Thanks.

 [1] https://lore.kernel.org/git/xmqqttqxkmaq.fsf@gitster.g/