Re: using tree as attribute source is slow, was Re: Help troubleshoot performance regression cloning with depth: git 2.44 vs git 2.42

From: Junio C Hamano <gitster@pobox.com>
Date: May 2, 2024, 21:08 UTC
Message-ID: <xmqqbk5ndiqk.fsf@gitster.g>
In-Reply-To: <CAOLa=ZRe6eWJ_ZyH+HRq=6Lh0-xZ=1X2Z2f3HW4+EVXNquaDTQ@mail.gmail.com>

Karthik Nayak <karthik.188@gmail.com> writes:

Show 12 quoted lines

> Taylor Blau <me@ttaylorr.com> writes:
>
>> I could be misunderstanding the original intent of John's patch (the
>> commit message there isn't clear whether the change was intended to
>> target just check-attr or all of Git). But my hope is that it was the
>> former, which this patch preserves.
>>
>
> From the series [1] it becomes more clear that the intention was to
> target all commands.
>
> [1]: https://lore.kernel.org/git/pull.1577.v5.git.git.1697218770.gitgitgadget@gmail.com/

True.

We could drop [1/2] from the series in the meantime to make it a GitLab installation specific issue where they explicitly use attr.tree to point at HEAD ;-) That is not solving anything for those who set attr.tree (in a sense, they are buying the feature with overhead of reading attributes from the named tree), but at least for most people who are used to seeing the bare repository ignoring the attributes, it would be an improvement to drop the "bare repositories the tree of the HEAD commit is used to look up attributes files by default" half from the series.