Re: [PATCH] attr.tree: HEAD:.gitattributes is no longer the default in a bare repo

From: Jeff King <peff@peff.net>
Date: Jun 6, 2024, 08:32 UTC
Message-ID: <20240606083216.GE658959@coredump.intra.peff.net>
In-Reply-To: <xmqqa5jzqd5k.fsf_-_@gitster.g>

On Wed, Jun 05, 2024 at 02:43:03PM -0700, Junio C Hamano wrote:

Show 8 quoted lines

> 51441e64 (stop using HEAD for attributes in bare repository by
> default, 2024-05-03) has addressed a recent performance regression
> by partially reverting a topic that was merged at 26dd307c (Merge
> branch 'jc/attr-tree-config', 2023-10-30).  But it forgot to update
> the documentation to remove the mention of a special case in bare
> repositories.
> 
> Let's update the document before the update hits the next release.

Good catch, and the patch looks good.

I think 51441e64 is essentially a revert of 2386535511 (attr: read attributes from HEAD when bare repo, 2023-10-13). I don't know how you prepared it, but I'd probably have started with "cherry-pick -n". But that wouldn't help, because the documentation didn't come until after that in 9f9c40cf34 (attr: add attr.tree for setting the treeish to read attributes from, 2023-10-13).

Not that it really matters much now, but always just curious about how we can avoid missing stuff like this next time.

-Peff