Re: [PATCH 17/19] environment: move compression level into repo settings

From: Junio C Hamano <gitster@pobox.com>
Date: Jul 11, 2025, 18:55 UTC
Message-ID: <xmqqbjpq1rs0.fsf@gitster.g>
In-Reply-To: <32fceddc-c867-4a47-bde8-c873279edbc1@gmail.com>

Phillip Wood <phillip.wood123@gmail.com> writes:

Show 6 quoted lines

> I do not think adding prepare_repo_settings() calls all over the place
> is a good way forward as it makes it very easy to introduce
> regressions like this. Our builtin commands parse the config at
> startup for good reasons if we're going to move settings out of
> git_default_core_config() we should ensure that they are still parsed
> at startup.

I think that is a good guideline that applies not just to this series but to other topics that attempt to move globals to a member in struct repository (or repository_settings)

Thanks. .

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.