Re: [PATCH 02/19] object-file: stop using `the_hash_algo`
Patrick Steinhardt <ps@pks.im> writes:
Show 7 quoted lines
> There are a couple of users of the `the_hash_algo` macro, which
> implicitly depends on `the_repository`. Adapt these callers to not do so
> anymore, either by deriving it from already-available context or by
> using `the_repository->hash_algo`. The latter variant doesn't yet help
> to remove the global dependency, but such users will be adapted in the
> following commits to not use `the_repository` anymore, either.
>
The 'either' doesn't make sense here.
Show 16 quoted lines
>
> Signed-off-by: Patrick Steinhardt <ps@pks.im>
> ---
> object-file.c | 40 ++++++++++++++++++++++++----------------
> object-file.h | 1 +
> 2 files changed, 25 insertions(+), 16 deletions(-)
>
> diff --git a/object-file.c b/object-file.c
> index 987cf289420..bc395febc9d 100644
> --- a/object-file.c
> +++ b/object-file.c
> @@ -25,6 +25,7 @@
> #include "pack.h"
> #include "packfile.h"
> #include "path.h"
> +#include "read-cache-ll.h"
I wonder why we add this header.
The rest of the patch looks good.
[snip]
Karthik Nayak <karthik.188@gmail.com>