Re: [PATCH v4 2/3] replay: make atomic ref updates the default behavior

From: Junio C Hamano <gitster@pobox.com>
Date: Oct 24, 2025, 15:23 UTC
Message-ID: <xmqqbjlwqq6d.fsf@gitster.g>
In-Reply-To: <CAP8UFD00rE7gF+baidmoi7nYwVKa3UDQgj+TB4wJLtjJF7u9gA@mail.gmail.com>

Christian Couder <christian.couder@gmail.com> writes:

Show 8 quoted lines

> On Wed, Oct 22, 2025 at 8:51 PM Siddharth Asthana
> <siddharthasthana31@gmail.com> wrote:
>
>> -       const char * const replay_usage[] = {
>> +       const char *const replay_usage[] = {
>
> Nit: Not sure this change is worth it, but I understand that it might
> help pass some automated/CI tests, so not a big issue.

I think this formatting issue came up recently on another discussion thread. We found that the prevalent style in the codebase is that an asterisk in between tokens neither of which is variable has space on both sides (i.e. the preimage of the above change), so unless there is a specific reason to make the above change, I'd rather not to see such "reformatting" thrown into a patch that implements a feature or fixes a bug (iow, not a "clean-up styles" patch).

By the way, I would be suprised if that the reason were a CI test. How would the preimage have been passing the same test if that is the case?