Re: [PATCH v4 3/3] replay: add replay.refAction config option
- From
Siddharth Asthana <siddharthasthana31@gmail.com>
- Date
- Oct 28, 2025, 19:47 UTC
- Message-ID
- <84729f5b-87a5-4a5e-a875-c28ddcea3b5b@gmail.com>
- In-Reply-To
- <7a3161d1-4e30-4156-876d-7eede4b06705@gmail.com>
On 24/10/25 19:06, Phillip Wood wrote:
Show 12 quoted lines
> On 24/10/2025 14:28, Phillip Wood wrote: >> On 22/10/2025 19:50, Siddharth Asthana wrote: >> >>> + git replay --onto main topic1..topic2 >output && >>> + test_line_count = 1 output && >>> + grep "^update refs/heads/topic2 " output && >> >> Rather than test_line_count and grep it would be better to use >> test_cmp here. > > Oh, I've just realized we don't know the value of the ref so > test_line_count() plus test_grep() (not grep) makes sense.
Exactly, since we can't predict the exact hash values, `test_line_count` + `test_grep` is the right approach. I will definitely switch from `grep` to `test_grep` as you and Christian both suggested.
Thanks, Siddharth
Show 5 quoted lines
> > Thanks > > Phillip >