Re: [PATCH v4 0/3] replay: make atomic ref updates the default
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Oct 23, 2025, 18:47 UTC
- Message-ID
- <xmqq7bwlv4jh.fsf@gitster.g>
- In-Reply-To
- <20251022185045.29256-1-siddharthasthana31@gmail.com>
Siddharth Asthana <siddharthasthana31@gmail.com> writes:
Show 23 quoted lines
> This is v4 of the git-replay atomic updates series. > > Based on feedback from v3, this version improves the naming and > implementation for clarity and type safety. Thanks to Junio, Christian, > Elijah, Phillip, Patrick, and Karthik for the detailed reviews. > > ## Changes in v4 > > **Renamed --update-refs to --ref-action** > > Junio pointed out that "--update-refs=print" is semantically awkward. > Answering "print" to the question "update refs?" doesn't make sense. > The actual question is "what action should we take on the refs?" > > Changed to --ref-action=(update|print) where both values are verbs that > answer "what action?". This makes the interface clearer. > > **Aligned config name with command-line option** > > Changed replay.defaultAction to replay.refAction. The config variable > now mirrors the option name, making the relationship obvious. > > **Unified config and command-line values**
I didn't see anything glaringly wrong in this round, even though I picked a couple of small nits in one patch, so we might want a hopefully small and final reroll before marking the topic for 'next'.
Is everybody else happy with this iteration otherwise?
Thanks.