Re: [PATCH] Makefile: fix up lib directory move

From: Junio C Hamano <gitster@pobox.com>
Date: Jul 12, 2026, 14:02 UTC
Message-ID: <xmqqbjcc5mro.fsf@gitster.g>
In-Reply-To: <ef422523-1c50-ec79-e89a-f43f02ba1ca7@gmx.de>

Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:

Show 11 quoted lines

> Hi Ramsay,
>
> On Fri, 10 Jul 2026, Ramsay Jones wrote:
>
>> Commit 9759608622 ("Move libgit.a sources into separate "lib/" directory",
>
> It's not your fault, but this commit is no longer reachable from any
> official branch.
>
> Maybe a more stable way to refer to this right now would be to name the
> topic: `ps/libgit-in-subdir`.

Yes, citing the object name alone would have been useless.

On the other hand, it is good to have it as a sanity-checking clue. If or when the patch does not apply cleanly, we can tell that the fix-up was written based on an older iteration. The "reference" format used here carries more information than the topic branch name alone, and with the commit title, we can run

    $ git show 'origin/seen^{/^Move libgit\.a sources into}'

when 9759608622 cannot be found.

Show 10 quoted lines

>> 2026-06-22) moved some files into a lib directory, but forgot to update
>> a sparse dependency in the Makefile, resulting in a sparse error:
>> 
>>       SP lib/pack-revindex.c
>>   lib/pack-revindex.c:78:17: error: memset with byte count of 262144
>>   make: *** [Makefile:3446: lib/pack-revindex.sp] Error 1
>> 
>> Add the missing 'lib/' prefix to the pack-revindex.sp path.
>
> That reasoning and that patch make sense to me. Thank you!

Yes, indeed.  It is queued on top of the topic.

Thanks.