Re: [PATCH] Makefile: fix up lib directory move

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Jul 12, 2026, 10:15 UTC
Message-ID: <ef422523-1c50-ec79-e89a-f43f02ba1ca7@gmx.de>
In-Reply-To: <0c94331b-7eb1-4116-afa5-811082ad5854@ramsayjones.plus.com>

Hi Ramsay,

On Fri, 10 Jul 2026, Ramsay Jones wrote:

> Commit 9759608622 ("Move libgit.a sources into separate "lib/" directory",

It's not your fault, but this commit is no longer reachable from any official branch.

Maybe a more stable way to refer to this right now would be to name the topic: `ps/libgit-in-subdir`.

Show 8 quoted lines

> 2026-06-22) moved some files into a lib directory, but forgot to update
> a sparse dependency in the Makefile, resulting in a sparse error:
> 
>       SP lib/pack-revindex.c
>   lib/pack-revindex.c:78:17: error: memset with byte count of 262144
>   make: *** [Makefile:3446: lib/pack-revindex.sp] Error 1
> 
> Add the missing 'lib/' prefix to the pack-revindex.sp path.

That reasoning and that patch make sense to me. Thank you!

Show 9 quoted lines

> 
> Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
> ---
> 
> Hi Patrick,
> 
> If you need to re-roll your 'ps/libgit-in-subdir' branch, could you please squash
> this into the relevant patch. (This patch was created directly on top of the 'seen'
> branch, rather than on top of your branch).

That would be 8da3a2c01822 (Move libgit.a sources into separate "lib/" directory, 2026-07-01), at least at the time of writing (that commit is still not merged into `next` and hence subject to be rewritten).

Ciao, Johannes

Show 27 quoted lines

> 
> Thanks
> 
> ATB,
> Ramsay Jones
> 
> 
>  Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Makefile b/Makefile
> index 703772ba4f..a36d2c1942 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -2974,7 +2974,7 @@ lib/gettext.sp lib/gettext.s lib/gettext.o: EXTRA_CPPFLAGS = \
>  http-push.sp lib/http.sp lib/http-walker.sp remote-curl.sp imap-send.sp: SP_EXTRA_FLAGS += \
>  	-DCURL_DISABLE_TYPECHECK
>  
> -pack-revindex.sp: SP_EXTRA_FLAGS += -Wno-memcpy-max-count
> +lib/pack-revindex.sp: SP_EXTRA_FLAGS += -Wno-memcpy-max-count
>  
>  ifdef NO_EXPAT
>  lib/http-walker.sp lib/http-walker.s lib/http-walker.o: EXTRA_CPPFLAGS = -DNO_EXPAT
> -- 
> 2.55.0
> 
>