git/list[1] front-page[2] threads[3] people[4] search[5] about
wed 2026-10-07 16:58 UTC

[PATCH] Makefile: fix up lib directory move

From
Ramsay Jones <ramsay@ramsayjones.plus.com>
Date
Jul 10, 2026, 18:38 UTC
Message-ID
<0c94331b-7eb1-4116-afa5-811082ad5854@ramsayjones.plus.com>

Commit 9759608622 ("Move libgit.a sources into separate "lib/" directory", 2026-06-22) moved some files into a lib directory, but forgot to update a sparse dependency in the Makefile, resulting in a sparse error:

      SP lib/pack-revindex.c
  lib/pack-revindex.c:78:17: error: memset with byte count of 262144
  make: *** [Makefile:3446: lib/pack-revindex.sp] Error 1
Add the missing 'lib/' prefix to the pack-revindex.sp path.
Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
---
Hi Patrick,

If you need to re-roll your 'ps/libgit-in-subdir' branch, could you please squash this into the relevant patch. (This patch was created directly on top of the 'seen' branch, rather than on top of your branch).

Thanks

ATB, Ramsay Jones

 Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Makefile b/Makefile
index 703772ba4f..a36d2c1942 100644
--- a/Makefile
+++ b/Makefile
@@ -2974,7 +2974,7 @@ lib/gettext.sp lib/gettext.s lib/gettext.o: EXTRA_CPPFLAGS = \
 http-push.sp lib/http.sp lib/http-walker.sp remote-curl.sp imap-send.sp: SP_EXTRA_FLAGS += \
 	-DCURL_DISABLE_TYPECHECK
 
-pack-revindex.sp: SP_EXTRA_FLAGS += -Wno-memcpy-max-count
+lib/pack-revindex.sp: SP_EXTRA_FLAGS += -Wno-memcpy-max-count
 
 ifdef NO_EXPAT
 lib/http-walker.sp lib/http-walker.s lib/http-walker.o: EXTRA_CPPFLAGS = -DNO_EXPAT
-- 
2.55.0
Next: Johannes Schindelin
Message 1 of 5 in “Makefile: fix up lib directory move”
  1. Makefile: fix up lib directory moveRamsay Jones, Jul 10, 2026
  2. Johannes SchindelinJul 12, 2026
  3. Ramsay JonesJul 12, 2026
  4. Junio C HamanoJul 12, 2026
  5. Patrick SteinhardtJul 13, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.