Re: [PATCH 03/10] t4209: factor out helper function test_log_icase()

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 24, 2014, 18:22 UTC
Message-ID: <xmqqa9cfqwwp.fsf@gitster.dls.corp.google.com>
In-Reply-To: <1395508560-19893-4-git-send-email-l.s.r@web.de>

René Scharfe <l.s.r@web.de> writes:

Show 21 quoted lines

> Reduce code duplication by introducing test_log_icase() that runs the
> same test with both --regexp-ignore-case and -i.  The specification of
> the four basic test scenarios (matching/nomatching combined with case
> sensitive/insensitive) becomes easier to read and write.
>
> Signed-off-by: Rene Scharfe <l.s.r@web.de>
> ---
>  t/t4209-log-pickaxe.sh | 25 +++++++++++++------------
>  1 file changed, 13 insertions(+), 12 deletions(-)
>
> diff --git a/t/t4209-log-pickaxe.sh b/t/t4209-log-pickaxe.sh
> index 9f3bb40..dd911c2 100755
> --- a/t/t4209-log-pickaxe.sh
> +++ b/t/t4209-log-pickaxe.sh
> @@ -25,6 +25,11 @@ test_log() {
>  	"
>  }
>  
> +test_log_icase() {
> +	test_log $@ --regexp-ignore-case
> +	test_log $@ -i

&&-cascade broken?  Will squash in an obvious fix.

> +}