git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 03/10] t4209: factor out helper function test_log_icase()

From
Jeff King <peff@peff.net>
Date
Mar 24, 2014, 21:10 UTC
Message-ID
<20140324211006.GA13728@sigill.intra.peff.net>
In-Reply-To
<xmqqa9cfqwwp.fsf@gitster.dls.corp.google.com>
On Mon, Mar 24, 2014 at 11:22:30AM -0700, Junio C Hamano wrote:
Show 5 quoted lines
> > +test_log_icase() {
> > +	test_log $@ --regexp-ignore-case
> > +	test_log $@ -i
> 
> &&-cascade broken?  Will squash in an obvious fix.

I don't think so. This is happening outside of test_expect_success, which is run by test_log. So adding a && means that if the first test fails, we do not bother to run the second one at all, which is not what we want.

-Peff
Previous: Junio C HamanoNext: René Scharfe
Message 6 of 21 in “pickaxe: honor -i when used with -S and --pickaxe-regex; cleanups”
  1. 00/10 pickaxe: honor -i when used with -S and --pickaxe-regex; cleanupsRené Scharfe, Mar 22, 2014
  2. 01/10 t4209: set up expectations up frontRené Scharfe, Mar 22, 2014
  3. 02/10 t4209: factor out helper function test_log()René Scharfe, Mar 22, 2014
  4. 03/10 t4209: factor out helper function test_log_icase()René Scharfe, Mar 22, 2014
  5. Junio C HamanoMar 24, 2014
  6. Jeff KingMar 24, 2014
  7. René ScharfeMar 24, 2014
  8. Junio C HamanoMar 24, 2014
  9. 04/10 t4209: use helper functions to test --grepRené Scharfe, Mar 22, 2014
  10. Junio C HamanoMar 24, 2014
  11. Jeff KingMar 24, 2014
  12. René ScharfeMar 24, 2014
  13. 05/10 t4209: use helper functions to test --authorRené Scharfe, Mar 22, 2014
  14. 06/10 pickaxe: honor -i when used with -S and --pickaxe-regexRené Scharfe, Mar 22, 2014
  15. 07/10 pickaxe: merge diffcore_pickaxe_grep() and diffcore_pickaxe_count() into diffcore_pickaxe()René Scharfe, Mar 22, 2014
  16. 08/10 pickaxe: move pickaxe() after pickaxe_match()René Scharfe, Mar 22, 2014
  17. Jeff KingMar 24, 2014
  18. 09/10 pickaxe: call strlen only when necessary in diffcore_pickaxe_count()René Scharfe, Mar 22, 2014
  19. 10/10 pickaxe: simplify kwset loop in contains()René Scharfe, Mar 22, 2014
  20. Junio C HamanoMar 24, 2014
  21. Jeff KingMar 24, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.