[PATCH 03/10] t4209: factor out helper function test_log_icase()
- From
René Scharfe <l.s.r@web.de>
- Date
- Mar 22, 2014, 17:15 UTC
- Message-ID
- <1395508560-19893-4-git-send-email-l.s.r@web.de>
- In-Reply-To
- <1395508560-19893-1-git-send-email-l.s.r@web.de>
Reduce code duplication by introducing test_log_icase() that runs the same test with both --regexp-ignore-case and -i. The specification of the four basic test scenarios (matching/nomatching combined with case sensitive/insensitive) becomes easier to read and write.
Signed-off-by: Rene Scharfe <l.s.r@web.de> --- t/t4209-log-pickaxe.sh | 25 +++++++++++++------------ 1 file changed, 13 insertions(+), 12 deletions(-)
diff --git a/t/t4209-log-pickaxe.sh b/t/t4209-log-pickaxe.sh index 9f3bb40..dd911c2 100755 --- a/t/t4209-log-pickaxe.sh +++ b/t/t4209-log-pickaxe.sh @@ -25,6 +25,11 @@ test_log() { " } +test_log_icase() { + test_log $@ --regexp-ignore-case + test_log $@ -i +} + test_expect_success setup ' >expect_nomatch && @@ -66,12 +71,10 @@ test_expect_success 'log --author -i' ' test_cmp expect_second actual ' -test_log expect_nomatch -G picked -test_log expect_second -G Picked -test_log expect_nomatch -G pickle --regexp-ignore-case -test_log expect_nomatch -G pickle -i -test_log expect_second -G picked --regexp-ignore-case -test_log expect_second -G picked -i +test_log expect_nomatch -G picked +test_log expect_second -G Picked +test_log_icase expect_nomatch -G pickle +test_log_icase expect_second -G picked test_expect_success 'log -G --textconv (missing textconv tool)' ' echo "* diff=test" >.gitattributes && @@ -86,12 +89,10 @@ test_expect_success 'log -G --no-textconv (missing textconv tool)' ' rm .gitattributes ' -test_log expect_nomatch -S picked -test_log expect_second -S Picked -test_log expect_second -S picked --regexp-ignore-case -test_log expect_second -S picked -i -test_log expect_nomatch -S pickle --regexp-ignore-case -test_log expect_nomatch -S pickle -i +test_log expect_nomatch -S picked +test_log expect_second -S Picked +test_log_icase expect_second -S picked +test_log_icase expect_nomatch -S pickle test_expect_success 'log -S --textconv (missing textconv tool)' ' echo "* diff=test" >.gitattributes &&
-- 1.9.1