Re: [PATCH 4/5] push.c: add an --atomic-push argument
Stefan Beller <sbeller@google.com> writes:
Show 8 quoted lines
> From: Ronnie Sahlberg <sahlberg@google.com>
>
> Add a command line argument to the git push command to request atomic
> pushes.
>
> Signed-off-by: Ronnie Sahlberg <sahlberg@google.com>
> Signed-off-by: Stefan Beller <sbeller@google.com>
> ---
Makes sense, modulo a nit.
Show 5 quoted lines
> +--atomic-push::
> + Using atomic push. If atomic push is negotiated with the server
> + then any push covering multiple refs will be atomic. Either all
> + refs are updated, or on error, no refs are updated. If the server
> + does not support atomic pushes the push will fail.
"git push --atomic-push"? Why should one need to repeat the word?
> OPT_BIT(0, "signed", &flags, N_("GPG sign the push"), TRANSPORT_PUSH_CERT),
> + OPT_BIT(0, "atomic-push", &flags, N_("use atomic push, if available"),
> + TRANSPORT_ATOMIC_PUSH),Contrast between the two. It isn't "git push --signed-push", either ;-)
Junio C Hamano <gitster@pobox.com>