From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 15 Dec 2014 21:50:16 GMT
Subject: Re: [PATCH 4/5] push.c: add an --atomic-push argument
Message-ID: <xmqqa92od1lz.fsf@gitster.dls.corp.google.com>
In-Reply-To: <1418673368-20785-5-git-send-email-sbeller@google.com>

Stefan Beller <sbeller@google.com> writes:

> From: Ronnie Sahlberg <sahlberg@google.com>
>
> Add a command line argument to the git push command to request atomic
> pushes.
>
> Signed-off-by: Ronnie Sahlberg <sahlberg@google.com>
> Signed-off-by: Stefan Beller <sbeller@google.com>
> ---

Makes sense, modulo a nit.

> +--atomic-push::
> +	Using atomic push. If atomic push is negotiated with the server
> +	then any push covering multiple refs will be atomic. Either all
> +	refs are updated, or on error, no refs are updated. If the server
> +	does not support atomic pushes the push will fail.

"git push --atomic-push"?  Why should one need to repeat the word?

>  		OPT_BIT(0, "signed", &flags, N_("GPG sign the push"), TRANSPORT_PUSH_CERT),
> +		OPT_BIT(0, "atomic-push", &flags, N_("use atomic push, if available"),
> +			TRANSPORT_ATOMIC_PUSH),

Contrast between the two.  It isn't "git push --signed-push", either ;-)