Re: [PATCH 1/5] receive-pack.c: add protocol support to negotiate atomic-push

From: Stefan Beller <sbeller@google.com>
Date: Dec 15, 2014, 22:30 UTC
Message-ID: <CAGZ79kYJjnTaUJMhLWt5q76odqQ_zBifEgVbNLJFdv8BViCCQw@mail.gmail.com>
In-Reply-To: <xmqqy4q8d493.fsf@gitster.dls.corp.google.com>

On Mon, Dec 15, 2014 at 12:53 PM, Junio C Hamano <gitster@pobox.com> wrote:

Show 8 quoted lines

> Hmph, am I reading the patch to send-pack.c correctly?
>
> It detects if the other side supports the capability and leaves it
> in atomic_push_supported variable for later use, and also requests
> the feature to be activated when atomic_push is set, but I see no
> logic to link these two together, e.g. error out when atomic_push
> is true and atomic_push_supported is false (or turn it off with a
> warning, or whatever).

This is what you mean by

Show 7 quoted lines

>
>> +     if (args->use_atomic_push && !atomic_push_supported) {
>> +             fprintf(stderr, "Server does not support atomic-push.");
>> +             return -1;
>> +     }
>
> This check logically belongs to the previous step, no?

from the next patch? If so it will be part of the next reroll.

Thanks, Stefan